Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCHv2] fs: fat: use pack_hex_byte() instead of custom one | Date | Fri, 12 Mar 2010 00:12:18 +0900 |
| |
Andy Shevchenko <andy.shevchenko@gmail.com> writes:
> From: Andy Shevchenko <ext-andriy.shevchenko@nokia.com> > > Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@nokia.com>
Looks good to me.
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
(From 1/4 with previous patch, I guess it's series of patches) Or I should take this patch into my tree?
Thanks.
> --- > fs/fat/dir.c | 14 +++++--------- > 1 files changed, 5 insertions(+), 9 deletions(-) > > diff --git a/fs/fat/dir.c b/fs/fat/dir.c > index 530b4ca..5de1a70 100644 > --- a/fs/fat/dir.c > +++ b/fs/fat/dir.c > @@ -19,6 +19,7 @@ > #include <linux/buffer_head.h> > #include <linux/compat.h> > #include <asm/uaccess.h> > +#include <linux/kernel.h> > #include "fat.h" > > /* > @@ -149,19 +150,14 @@ static int uni16_to_x8(unsigned char *ascii, const wchar_t *uni, int len, > > while (*ip && ((len - NLS_MAX_CHARSET_SIZE) > 0)) { > ec = *ip++; > - if ( (charlen = nls->uni2char(ec, op, NLS_MAX_CHARSET_SIZE)) > 0) { > + if ((charlen = nls->uni2char(ec, op, NLS_MAX_CHARSET_SIZE)) > 0) { > op += charlen; > len -= charlen; > } else { > if (uni_xlate == 1) { > - *op = ':'; > - for (k = 4; k > 0; k--) { > - nc = ec & 0xF; > - op[k] = nc > 9 ? nc + ('a' - 10) > - : nc + '0'; > - ec >>= 4; > - } > - op += 5; > + *op++ = ':'; > + op = pack_hex_byte(op, ec >> 8); > + op = pack_hex_byte(op, ec); > len -= 5; > } else { > *op++ = '?';
-- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |