lkml.org 
[lkml]   [2010]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 04/11] ST SPEAr: Added basic header files for SPEAr platform
From
2010/3/10 Viresh KUMAR <viresh.kumar@st.com>:
> Linus Walleij:
>> If this file is only supposed to be used from plat-spear/time.c, move it down
>> into plat-spear/gpt.h and #include "gpt.h" so noone else will
>> accidentally use it.
>
> GPT's on SPEAr can be used from time.c, platform specific drivers and machine
> specific drivers or any driver wishing to use hardware timer.
> In first two cases "gpt.h" will work, but in rest of cases we need gpt.h to be
> in plat-spear/include/plat
>
> Is it okay?

If you have or have already planned to write such platform, machine
or subsystem drivers, it's OK, if there are no such users and you cannot
easily give one, it's overdesigned IMHO. Some realistic examples of such
drivers will make me change my mind :-)

The reason I persist is that I've seen such unutilized timer API:s before and
no other user than the system timer in sight. I never understood what they
were to be used for, and I still don't, so help me understand. The kernel
has many internal timer API:s based on clockevent available already so
why add yet another, platform-specific one?

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2010-03-10 10:33    [W:0.095 / U:4.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site