lkml.org 
[lkml]   [2010]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: ATA 4 KiB sector issues.
On Wed, 10 Mar 2010, Martin K. Petersen wrote:
> >>>>> "Karel" == Karel Zak <kzak@redhat.com> writes:
>
> [Cleaned up the CC: list from hell]
>
> Karel> # cat /sys/block/md8/queue/{minimum,optimal}_io_size
> Karel> 65536 65536
>
> This one had me puzzled. We set min_io and opt_io correctly in raid5.c
> depending on number of non-parity disks. And yet it turns into
> something nonsensical after.
>
> Turns out we overrun unsigned int calculating the lowest common multiple
> in the stacking function. That's why we ended up with the wrong value.
>
> I never noticed this because my userland topology regression test tool
> uses unsigned long.
>
> I'll get a patch off to Jens right away.

And please get the whole fixed deal in -stable eventually, for 2.6.32.y's
benefit :-)

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh


\
 
 \ /
  Last update: 2010-03-10 21:53    [W:0.145 / U:8.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site