lkml.org 
[lkml]   [2010]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH -mm] call_usermodehelper: call info->init() after set_user_nice()
Mostly cosmetic, but imho it makes sense to call sub_info->init() right
before kernel_execve(). This looks more natural and allows ->init() hook
to change the priority if needed.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---

kernel/kmod.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)

--- mm/kernel/kmod.c~5_MOVE_INIT_DOWN 2010-03-10 17:36:37.000000000 +0100
+++ mm/kernel/kmod.c 2010-03-10 19:40:24.000000000 +0100
@@ -159,6 +159,11 @@ static int ____call_usermodehelper(void

/* We can run anywhere, unlike our parent keventd(). */
set_cpus_allowed_ptr(current, cpu_all_mask);
+ /*
+ * Our parent is keventd, which runs with elevated scheduling priority.
+ * Avoid propagating that into the userspace child.
+ */
+ set_user_nice(current, 0);

if (sub_info->init) {
retval = sub_info->init(sub_info);
@@ -166,14 +171,7 @@ static int ____call_usermodehelper(void
goto fail;
}

- /*
- * Our parent is keventd, which runs with elevated scheduling priority.
- * Avoid propagating that into the userspace child.
- */
- set_user_nice(current, 0);
-
retval = kernel_execve(sub_info->path, sub_info->argv, sub_info->envp);
-
/* Exec failed? */
fail:
sub_info->retval = retval;


\
 
 \ /
  Last update: 2010-03-10 19:53    [W:0.037 / U:1.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site