Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: [PATCH 2/3] input: use input_mutex instead of BKL when opening input device | Date | Tue, 9 Mar 2010 22:56:38 -0800 |
| |
On Tuesday 09 March 2010 10:49:20 pm Oliver Neukum wrote: > Am Mittwoch, 10. März 2010 07:20:15 schrieb Dmitry Torokhov: > > > I was willing to let the open call go unprotected. But ended up > > > checking that the three callees were fine (they do not call any of the > > > other functions that take the mutex). > > > > > > Since the fops_put/fops_get do protect that section from the handler > > > removal and I can't think of any other race right now, I think your > > > version is really better. > > > > > > Acked-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com> > > > > OK, applied 2 Thadeu's patches and one Arnd's. > > Jiri, > > it is possible that this requires a change in usbhid as it uses BKL. > Do you remember? >
No, different layer altogether.
-- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |