lkml.org 
[lkml]   [2010]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] Loongson-2F: Flush the branch target history such as BTB and RAS
From
Date
Hi,

Thanks very much for your careful review, will resend a new one later.

Regards,
Wu Zhangjin

On Wed, 2010-03-10 at 13:44 +0300, Sergei Shtylyov wrote:
[...]
> > diff --git a/arch/mips/include/asm/stackframe.h b/arch/mips/include/asm/stackframe.h
> > index 3b6da33..b84cfda 100644
> > --- a/arch/mips/include/asm/stackframe.h
> > +++ b/arch/mips/include/asm/stackframe.h
> > @@ -121,6 +121,25 @@
> > .endm
> > #else
> > .macro get_saved_sp /* Uniprocessor variation */
> > +#ifdef CONFIG_CPU_LOONGSON2F
> > + /*
> > + * Clear BTB(branch target buffer), forbid RAS(row address
> > + * strobe)
>
> No spaces before the left paren...
>
> > to workaround the Out-of-oder Issue in Loongson2F
> > + * via it's diagnostic register.
> >
>
> Only "its".
>
> > + */
> > + move k0, ra
> >
>
> Operands misalined...
>
> WBR, Sergei
>
>




\
 
 \ /
  Last update: 2010-03-10 16:33    [W:0.113 / U:3.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site