lkml.org 
[lkml]   [2010]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: smatch_scripts/whitespace_only.sh
On Wed, 10 Mar 2010, Dan Carpenter wrote:

> On Wed, Mar 10, 2010 at 11:14:53AM +0100, Julia Lawall wrote:
> > On Wed, 10 Mar 2010, Dan Carpenter wrote:
> >
> > > I wrote a script to check that a patch only changes white space.
> > > It compiles the files before and after the patch is applied and
> > > verifies that they are the same.
> > >
> > > You'll need to compile smatch:
> > > git pull git://repo.or.cz/smatch.git
> > > make
> > > cd /path/to/kernel/src/
> > > /path/to/smatch_scripts/whitespace_only.sh <patch>
> > >
> > > Adding or removing parenthesis and curly braces counts as a code
> > > change. Changes to comments, #if 0, white space changes do not.
> > >
> > > You can fix a lot of style violations if you limit yourself to
> > > adding and removing tabs, spaces and new lines. Then the next
> > > patch could remove unneeded parenthesis. It would be easier to
> > > audit that way instead of everything mixed together.
> > >
> > > regards,
> > > dan carpenter
> > >
> > > PS. I feel really bad slagging the newbies trying to help.
> > > Could we fix checkpatch.pl to not complain about line lengths?
> >
> > I hope not... Are newbies really put off by having to add a newline here
> > and there?
> >
> > julia
> >
>
> The problem is that newbies are only too happy to chop lines up into smaller
> and smaller bits. :P I've seen situations where the actual author of the code
> broke up _his own_ perfectly reasonable code into tiny chunks just to satisfy
> checkpatch.pl.
>
> printk("blah blah blah blah"
> "blah blah"
> "blah");
>
> It would be great if people dealt with checkpatch warnings by breaking
> things out into separate functions and eliminating indent levels but
> that never happens.

Maybe checkpatch could be changed to not complain about > 80 characters
when the line contains a string?

julia


\
 
 \ /
  Last update: 2010-03-10 15:41    [W:0.051 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site