lkml.org 
[lkml]   [2010]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH]: cleanup debug message in init_kstat_irqs()
Cleanup a debug message in init_kstat_irqs().

This debug message can result in valid output like

alloc kstat_irqs on node -1

which looks alot like an error message.

This debug statement has been in the kernel for over a year, so I think it is
safe to remove it and report the node in only the error case instead.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>

diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 76d5a67..e7fb871 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -94,10 +94,10 @@ void __ref init_kstat_irqs(struct irq_desc *desc, int node, int nr)
* don't overwite if can not get new one
* init_copy_kstat_irqs() could still use old one
*/
- if (ptr) {
- printk(KERN_DEBUG " alloc kstat_irqs on node %d\n", node);
+ if (ptr)
desc->kstat_irqs = ptr;
- }
+ else
+ printk(KERN_ERR " alloc kstat_irqs on node %d failed\n", node);
}


\
 
 \ /
  Last update: 2010-03-10 15:07    [W:0.019 / U:2.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site