lkml.org 
[lkml]   [2010]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Security: Fix return value of avc_has_perm_noaudit() in security/selinux/avc.c
From
Date
On Thu, 2010-03-11 at 04:53 +0800, wzt.wzt@gmail.com wrote:
> avc_has_perm_noaudit() is not check the return value of avc_update_node, avc_update_node() delcared as int.
>
> Signed-off-by: Zhitong Wang <zhitong.wangzt@alibaba-inc.com>

NAK. Just cast to void instead. This is on the permissive code path
and failure to update the node is non-fatal (just means we'll try again
next time) and should not cause the permission to be denied.

>
> ---
> security/selinux/avc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/security/selinux/avc.c b/security/selinux/avc.c
> index f2dde26..8bbce96 100644
> --- a/security/selinux/avc.c
> +++ b/security/selinux/avc.c
> @@ -763,7 +763,7 @@ int avc_has_perm_noaudit(u32 ssid, u32 tsid,
> if (flags & AVC_STRICT)
> rc = -EACCES;
> else if (!selinux_enforcing || (avd->flags & AVD_FLAGS_PERMISSIVE))
> - avc_update_node(AVC_CALLBACK_GRANT, requested, ssid,
> + rc = avc_update_node(AVC_CALLBACK_GRANT, requested, ssid,
> tsid, tclass, avd->seqno);
> else
> rc = -EACCES;
--
Stephen Smalley
National Security Agency



\
 
 \ /
  Last update: 2010-03-10 13:59    [W:0.024 / U:2.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site