[lkml]   [2010]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH vfat] allow retrieving entries with trailing dots
Hello Ogawa,

This fixes accessing vfat entries with trailing dots created by an external
vfat driver (like the one in IOMEGA home network hard drives)



Some vfat-formatted network disks that are also usb disk do not discard
trailing dots when creating files or directories via ftp.
Connecting afterwards this drive via usb to a linux machine leads to the
following problem :
if one issues the `ls' or `find' command, one gets this message :

find: ./Simon_&_Garfunkel-Wednesday_Morning,_3_a.m.: No such file or directory

Fix that by first trying to retrieve the entry with the full name, and only if
that fails and there are trailing dots in the searched name, try then to find
the truncated name.

Signed-off-by: Philippe De Muyter <>

--- a/fs/fat/namei_vfat.c 2009-09-10 00:13:59.000000000 +0200
+++ b/fs/fat/namei_vfat.c 2010-02-08 02:28:37.010096903 +0100
@@ -702,9 +702,22 @@
static int vfat_find(struct inode *dir, struct qstr *qname,
struct fat_slot_info *sinfo)
- unsigned int len = vfat_striptail_len(qname);
+ int err;
+ unsigned int len;
+ /* Some combined ethernet + usb external hard drive do not
+ * remove the trailing dots when creating entries in ethernet mode.
+ * (e.g. Iomega Home Network Hard Drive)
+ * Make accessing those entries possible.
+ */
+ err = fat_search_long(dir, qname->name, qname->len, sinfo);
+ if (!err)
+ return err;
+ len = vfat_striptail_len(qname);
if (len == 0)
return -ENOENT;
+ if (len == qname->len)
+ return err;
return fat_search_long(dir, qname->name, len, sinfo);

 \ /
  Last update: 2010-03-10 13:35    [W:0.045 / U:15.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site