Messages in this thread | | | Date | Tue, 2 Mar 2010 08:04:47 +0900 | From | Paul Mundt <> | Subject | Re: [RFC] microblaze: Support FRAME_POINTER for better backtrace |
| |
On Thu, Feb 25, 2010 at 02:13:29PM -0600, Steven J. Magnani wrote: > diff -uprN a/arch/microblaze/Kconfig.debug b/arch/microblaze/Kconfig.debug > --- a/arch/microblaze/Kconfig.debug 2010-02-25 13:52:30.000000000 -0600 > +++ b/arch/microblaze/Kconfig.debug 2010-02-25 13:52:49.000000000 -0600 > @@ -26,4 +26,11 @@ config DEBUG_BOOTMEM > depends on DEBUG_KERNEL > bool "Debug BOOTMEM initialization" > > +config FRAME_POINTER > + bool "Use frame pointers" > + default n > + help > + If you say N here, the resulting kernel will be slightly smaller and > + faster. However, stack dumps will be much harder to interpret. > + > endmenu
This isn't necessary, as it already exists in lib/Kconfig.debug. You can add your architecture to the list there, or if you want it default enabled you can also select ARCH_WANT_FRAME_POINTERS.
> diff -uprN a/arch/microblaze/kernel/traps.c b/arch/microblaze/kernel/traps.c > --- a/arch/microblaze/kernel/traps.c 2010-02-25 13:50:00.000000000 -0600 > +++ b/arch/microblaze/kernel/traps.c 2010-02-25 13:51:11.000000000 -0600 > @@ -8,6 +8,7 @@ > * for more details. > */ > > +#include <generated/autoconf.h> > #include <linux/kernel.h> > #include <linux/kallsyms.h> > #include <linux/module.h>
No need for this either, it's pulled in by Kbuild.
| |