lkml.org 
[lkml]   [2010]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm: fix char constant (sparse warning)
On 03/01/10 09:06, Alex Deucher wrote:
> On Mon, Mar 1, 2010 at 1:01 AM, Dave Airlie <airlied@gmail.com> wrote:
>> On Thu, Feb 25, 2010 at 8:27 AM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>
>>> Fix radeon/atombios.h sparse warning (24 times):
>>>
>>> drivers/gpu/drm/radeon/atombios.h:4091:63: error: Bad character constant
>>
>> We get this file from AMD pretty much as-is and I hate deviating it as it
>> causes merge issues. Alex any change you can get this fixed upstream?

Ah, thanks for that info.

>>
>
> I can try.
>
> Alex

OK, thanks.

>> Dave.
>>
>>>
>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>> Cc: David Airlie <airlied@linux.ie>
>>> ---
>>> drivers/gpu/drm/radeon/atombios.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> --- linux-2.6.33-rc8.orig/drivers/gpu/drm/radeon/atombios.h
>>> +++ linux-2.6.33-rc8/drivers/gpu/drm/radeon/atombios.h
>>> @@ -4088,7 +4088,7 @@ typedef struct _SW_I2C_IO_DATA_PARAMETER
>>> #define SW_I2C_CNTL_WRITE1BIT 6
>>>
>>> /* ==============================VESA definition Portion=============================== */
>>> -#define VESA_OEM_PRODUCT_REV '01.00'
>>> +#define VESA_OEM_PRODUCT_REV "01.00"
>>> #define VESA_MODE_ATTRIBUTE_MODE_SUPPORT 0xBB /* refer to VBE spec p.32, no TTY support */
>>> #define VESA_MODE_WIN_ATTRIBUTE 7
>>> #define VESA_WIN_SIZE 64
>>> --


--
~Randy


\
 
 \ /
  Last update: 2010-03-01 18:21    [W:0.070 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site