lkml.org 
[lkml]   [2010]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] udf: use ext2_find_next_bit
    On Thu 25-02-10 10:38:25, Akinobu Mita wrote:
    > 2010/2/25 Jan Kara <jack@suse.cz>:
    > > On Tue 23-02-10 23:11:13, Akinobu Mita wrote:
    > >> Use ext2_find_next_bit (generic_find_next_le_bit) to find the set bit
    > >> in little endian bitmap region.
    > >>
    > >> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
    > >> Cc: Jan Kara <jack@suse.cz>
    > >  I've looked at the code and I think this is wrong. UDF uses 1 for free
    > > block in the bitmap and 0 for used one. So you need to use
    > > generic_find_next_le_bit...
    > >  Something like the patch below?
    >
    > According to include/asm-generic/bitops/ext2-non-atomic.h,
    > generic_find_next_le_bit() == ext2_find_next_bit().
    Ah, I'm really sorry. I've originally misread the header and thought that
    ext2_find_next_bit == generic_find_next_le_zero_bit. So my patch does
    exactly the same thing as yours. I've now merged your patch so that you get
    proper credit.

    > BTW, I realized that udf_find_first_one_bit() macro is not used.
    > So you can remove it in this patch.
    Yes, I've removed it now.

    Honza

    --
    Jan Kara <jack@suse.cz>
    SUSE Labs, CR
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-03-01 11:55    [W:2.385 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site