lkml.org 
[lkml]   [2010]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 28/35] radix: move radix init early
On 02/09/2010 11:56 AM, Pekka Enberg wrote:
> On Tue, Feb 9, 2010 at 9:49 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
>> On Tue, 09 Feb 2010 11:32:39 -0800
>> Yinghai Lu <yinghai@kernel.org> wrote:
>>
>>> prepare to use it in early_irq_init()
>>>
>>> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>>> ---
>>> init/main.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/init/main.c b/init/main.c
>>> index 4cb47a1..8451878 100644
>>> --- a/init/main.c
>>> +++ b/init/main.c
>>> @@ -584,6 +584,7 @@ asmlinkage void __init start_kernel(void)
>>> local_irq_disable();
>>> }
>>> rcu_init();
>>> + radix_tree_init();
>>> /* init some links before init_ISA_irqs() */
>>> early_irq_init();
>>> init_IRQ();
>>> @@ -657,7 +658,6 @@ asmlinkage void __init start_kernel(void)
>>> proc_caches_init();
>>> buffer_init();
>>> key_init();
>>> - radix_tree_init();
>>> security_init();
>>> vfs_caches_init(totalram_pages);
>>> signals_init();
>>
>> Probably OK. Note that radix_tree_init() uses slab, and it is now being
>> called before the kernel has run kmem_cache_init_late(). So please
>> ensure that this code was tested with CONFIG_SLAB=y.
>
> That should be fine but yeah, definitely needs to be tested.

tested with x86 bit with CONFIG_SLAB=y, and it works.

YH


\
 
 \ /
  Last update: 2010-02-10 01:19    [W:0.038 / U:4.776 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site