lkml.org 
[lkml]   [2010]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] obsolete config in kernel source (USB_GADGET_*)
On Fri, 5 Feb 2010, Christoph Egger wrote:

> On Fri, Jan 15, 2010 at 09:46:00AM -0500, Alan Stern wrote:
> > On Fri, 15 Jan 2010, Christoph Egger wrote:
> > > The linux tree contains USB-Id assignment snippets for some
> > > USB Gadget drivers, which, as far as I can tell, never worked on
> > > mainline linux2.6 but either originate from seemingly long-dead
> > > third-party trees or were never ported from linux2.4.
> > >
> > > As there has also seemingly never existed a way to select
> > > these configs in the KConfig system it might be time to get rid of
> > > them which would be done by the attached patch.
> >
> > Have you tried building g_file_storage and the other gadget drivers
> > after applying your patch?
>
> You're right. I ony checked whether the first few were still
> needed somewhere in code and assumed equal status for all of
> them. SHould have at least build-tested all that stuff before sending
> (and doing so now).
>
> Below is a updated patch that should be more correct and does
> also build (tested against mainline git).

The new patch looks okay to me. Other people might have opinions about
whether this code should be removed, however.

Alan Stern



\
 
 \ /
  Last update: 2010-02-08 15:53    [W:0.039 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site