Messages in this thread | | | Date | Sun, 07 Feb 2010 11:38:30 +0200 | From | Avi Kivity <> | Subject | Re: [PATCH 02/11] iommu-api: Add iommu_map and iommu_unmap functions |
| |
On 01/28/2010 01:37 PM, Joerg Roedel wrote: > These two functions provide support for mapping and > unmapping physical addresses to io virtual addresses. The > difference to the iommu_(un)map_range() is that the new > functions take a gfp_order parameter instead of a size. This > allows the IOMMU backend implementations to detect easier if > a given range can be mapped by larger page sizes. > These new functions should replace the old ones in the long > term. >
These seem to be less flexible in the long term. Sure, it is easier for the backend to map to multiple page sizes if your iommu supports arbitrary power-of-two page sizes, but we should make the APIs easier for the callers, not the backend.
-- error compiling committee.c: too many arguments to function
| |