Messages in this thread | | | Date | Sat, 6 Feb 2010 01:55:19 -0800 (PST) | From | David Rientjes <> | Subject | Re: [PATCH] [3/4] SLAB: Separate node initialization into separate function |
| |
On Sat, 6 Feb 2010, Andi Kleen wrote:
> > in the series; slab_node_prepare() is called in that previous patch by a > > memory hotplug callback without holding cache_chain_mutex (it's taken by > > the cpu hotplug callback prior to calling cpuup_prepare() currently). So > > slab_node_prepare() should note that we require the mutex and the memory > > hotplug callback should take it in the previous patch. > > AFAIK the code is correct. If you feel the need for additional > documentation feel free to send patches yourself. >
Documentation? You're required to take cache_chain_mutex before calling slab_node_prepare() in your memory hotplug notifier, it iterates cache_chain. Please look again.
| |