lkml.org 
[lkml]   [2010]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] Staging: samsung-laptop: fix coding style issues
On Fri, Feb 05, 2010 at 02:11:48AM -0300, Chihau Chau wrote:
> From: Chihau Chau <chihau@gmail.com>
>
> This fixes some lines over 80 characters coding style issues
>
> Signed-off-by: Chihau Chau <chihau@gmail.com>
> ---
> drivers/staging/samsung-laptop/samsung-laptop.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/samsung-laptop/samsung-laptop.c b/drivers/staging/samsung-laptop/samsung-laptop.c
> index 4877138..87ec773 100644
> --- a/drivers/staging/samsung-laptop/samsung-laptop.c
> +++ b/drivers/staging/samsung-laptop/samsung-laptop.c
> @@ -99,7 +99,8 @@ static struct rfkill *rfk;
>
> static int force;
> module_param(force, bool, 0);
> -MODULE_PARM_DESC(force, "Disable the DMI check and forces the driver to be loaded");
> +MODULE_PARM_DESC(force, "Disable the DMI check and forces the driver to be "
> + "loaded");

Um, care to move the whole string down one line to make it nicer to look
at?

> static int debug;
> module_param(debug, bool, S_IRUGO | S_IWUSR);
> @@ -370,7 +371,8 @@ static struct dmi_system_id __initdata samsung_dmi_table[] = {
> {
> .ident = "N128",
> .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> + DMI_MATCH(DMI_SYS_VENDOR,
> + "SAMSUNG ELECTRONICS CO., LTD."),

Like this, what you did here was fine, can you do this above as well and
resubmit the whole thing to me so I can apply it?

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-02-05 18:25    [from the cache]
©2003-2011 Jasper Spaans