[lkml]   [2010]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 03/11] tracing: Inject lock_class_init events on registration
On Fri, 2010-02-05 at 15:30 +0100, Peter Zijlstra wrote:
> On Fri, 2010-02-05 at 09:13 -0500, Steven Rostedt wrote:

> > register_event_callback("event", "command", command_func,
> > command_enable_func,
> > command_disable_func);
> >
> > Where command_func, command_enable_func and command_disable_func can all
> > be a function pointer or NULL.
> >
> > command_func gets called every time the event is hit while enabled.
> >
> > command_enable_func gets called when the event is enabled
> >
> > command_disable_func gets called when the event is disabled.
> Well, that will solve johill's polling thing, but not work nicely with
> the proposed collection iteration stuff.

Actually, johill and I decided that this was not the proper solution for
him ;-)

I wanted to do this so we could add a lot more functionality and
flexibility to events. Start the tracer when this event is hit, stop in
on that event, but only when the filters match. Things like that. And
I'm sure people could come up with much better and more imaginative
commands that would be useful for tracing.

What does not fit with this proposal? I really hate adding more macros
for every new feature or functionality we need. It is ugly and will
become a maintenance nightmare.

-- Steve

 \ /
  Last update: 2010-02-05 15:47    [W:0.069 / U:0.680 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site