Messages in this thread | | | Date | Thu, 4 Feb 2010 20:05:27 +0000 | From | Matthew Garrett <> | Subject | Re: [PATCH 4/9] x86: move hp-wmi's probe function to .devinit.text |
| |
On Thu, Feb 04, 2010 at 08:56:52PM +0100, Uwe Kleine-König wrote: > A pointer to hp_wmi_bios_setup is passed to the core via > platform_driver_register and so the function must not disappear when the > .init sections are discarded. Otherwise (if also having HOTPLUG=y) > unbinding and binding a device to the driver via sysfs will result in an > oops as does a device being registered late. > > An alternative to this patch is using platform_driver_probe instead of > platform_driver_register plus removing the pointer to the probe function > from the struct platform_driver. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Cc: Frans Pop <elendil@planet.nl> > Cc: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Len Brown <lenb@kernel.org> > Cc: Helge Deller <deller@gmx.de> > Cc: Matthew Garrett <mjg@redhat.com> > Cc: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Matthew Garrett <mjg@redhat.com>
-- Matthew Garrett | mjg59@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |