lkml.org 
[lkml]   [2010]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6/9] w1: move omap_hdq's probe function to .devinit.text
    Date
    A pointer to omap_hdq_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: Stanley.Miao <stanley.miao@windriver.com>
    Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Madhusudhan Chikkature <madhu.cr@ti.com>
    Cc: Felipe Balbi <felipe.balbi@nokia.com>
    ---
    drivers/w1/masters/omap_hdq.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
    index 0d92969..22977d3 100644
    --- a/drivers/w1/masters/omap_hdq.c
    +++ b/drivers/w1/masters/omap_hdq.c
    @@ -72,7 +72,7 @@ struct hdq_data {
    int init_trans;
    };

    -static int __init omap_hdq_probe(struct platform_device *pdev);
    +static int __devinit omap_hdq_probe(struct platform_device *pdev);
    static int omap_hdq_remove(struct platform_device *pdev);

    static struct platform_driver omap_hdq_driver = {
    @@ -558,7 +558,7 @@ static void omap_w1_write_byte(void *_hdq, u8 byte)
    return;
    }

    -static int __init omap_hdq_probe(struct platform_device *pdev)
    +static int __devinit omap_hdq_probe(struct platform_device *pdev)
    {
    struct hdq_data *hdq_data;
    struct resource *res;
    --
    1.6.6
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-02-04 21:01    [W:0.024 / U:1.300 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site