Messages in this thread | | | Date | Wed, 3 Feb 2010 23:08:47 -0800 | From | Andy Isaacson <> | Subject | Re: [2.6.33-rc6-git regression] idr fix breaks Xorg |
| |
On Thu, Feb 04, 2010 at 12:11:41PM +0900, Tejun Heo wrote: > On 02/04/2010 10:28 AM, Andy Isaacson wrote: > > On my Dell Latitude e4300 commit 859ddf0974 ("idr: fix a critical > > misallocation bug") causes Xorg to segfault with the following > > backtrace: > > Does the following patch make any difference? > > diff --git a/lib/idr.c b/lib/idr.c > index ba7d37c..a96c604 100644 > --- a/lib/idr.c > +++ b/lib/idr.c > @@ -140,7 +140,8 @@ static int sub_alloc(struct idr *idp, int *starting_id, struct idr_layer **pa) > id = *starting_id; > restart: > p = idp->top; > - l = p->layer; > + l = idp->layers; > + pa[l--] = NULL; > while (1) { > /* > * We run around this while until we reach the leaf node...
Alas, no -- with that patch applied Xorg still segfaults in the same place.
-andy
| |