Messages in this thread | | | Date | Thu, 04 Feb 2010 12:05:52 -0200 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes |
| |
Jiri Slaby wrote: > On 02/04/2010 02:41 PM, Mauro Carvalho Chehab wrote: >> The point is that it is better to name the function right since the beginning. > > Sorry, I misunderstood you for the first time. It's .event member of > hid_driver. Hence I named it dvb_event (or now rc_event or whatever). > > The function may contain decisions on what to do with the event based > for example on quirks set up in .probe. And if the function grows later, > it may be factored out to rc_nokeyup_event. But rc_event is a root for > the decision tree and it should be there forever. Does it make sense now?
Ah, ok. Due to the comments at the function, I misunderstood that you were planning to have separate functions for separate quirks.
--
Cheers, Mauro
| |