lkml.org 
[lkml]   [2010]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes
On Thu, 4 Feb 2010, Pekka Sarnila wrote:

> The FULLSPEED thing is really not ir receiver specific problem. It can
> happen with any device with interrupt endpoint. That's the reason why I
> placed the quirk to HID driver.
>
> However even the HID driver is logically a wrong place. Really it should
> belong to the usb/endpoint layer because this really is not HID specific
> problem but usb layer problem (as also Jiri Kosina then pointed out).
> However linux usb layer has been build so that it was technically
> impossible to put it there without completely redesigning usb <-> higher
> layer (including HID) interface. But I'm of the opinion that that
> redesign should be done anyway. Even when no quirk is needed interrupt
> endpoint handling is a usb level task not a hid level (or any other
> higher level) task. The usb layer should do the interrupt endpoint
> polling and just put up interrupt events to higher layers. Partly this
> confusion is due the poor usb/hid specifications. It really should be a
> device/endpoint-quirk.

Yes, I still think what I have stated before, that this should be properly
handled in the USB stack.

On the other hand, in usbhid driver we do a lot of USB-specific
lower-level things anyway, so it's technically more-or-less OK to apply
the quirk there as well (and that's why I have accepted it back then).

--
Jiri Kosina
SUSE Labs, Novell Inc.


\
 
 \ /
  Last update: 2010-02-04 14:31    [W:0.124 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site