Messages in this thread | | | Date | Thu, 04 Feb 2010 10:31:07 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH] perf tools: using O_LARGEFILE to open perf data file - fix |
| |
Ingo Molnar wrote: > * Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> wrote: > >> Setting _FILE_OFFSET_BITS and using O_LARGEFILE, lseek64, etc, is >> redundant. Thanks H. Peter Anvin for point out >> >> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> >> --- >> tools/perf/builtin-record.c | 3 +-- >> tools/perf/util/header.c | 21 ++++++++++----------- >> tools/perf/util/session.c | 3 +-- >> tools/perf/util/trace-event-read.c | 14 +++++++------- >> 4 files changed, 19 insertions(+), 22 deletions(-) > > i already applied the v1 patch - mind sending a delta patch that removes the > redundant definitions? >
Hi Ingo,
This patch is the delta patch, i used the _FILE_OFFSET_BITS defining and removed O_LARGEFILE/lseek64 to keep code clean.
I'll integrate Peter's comments and send the new version.
Thanks, Xiao
| |