lkml.org 
[lkml]   [2010]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2.6.33 1/4] net: Micrel KSZ8841/2 PCI Ethernet driver
From
From: "Ha, Tristram" <Tristram.Ha@Micrel.Com>
Date: Fri, 29 Jan 2010 14:37:22 -0800

> This is a resubmission of the Micrel KSZ8841/2 PCI Ethernet driver.

The procfs stuff is a non-starter.

There will undoubtedly be other devices that have switch-like
facilities that we'd like to export configuration support for.

The last thing we want is a bunch of procfs files that each
driver decides the layout and behavior of.

We need a centralized way to config such things, and probably
the best is to have a rtnl_link_ops facility to get at the
ports and configure them with attribute blobs or similar.

We also said in your first submission that the way you're
getting at the bridge STP stuff with things like:

+/* Needed for STP support. */
+#ifdef CONFIG_KSZ8842_STP
+#include <../net/bridge/br_private.h>
+#endif

Yet you left all of this stuff in there.


\
 
 \ /
  Last update: 2010-02-04 03:03    [W:0.050 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site