Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [patch] sysctl: clean up vm related variable declarations | Date | Wed, 3 Feb 2010 17:07:00 +0900 (JST) |
| |
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > Now, there are many "extern" declaration in kernel/sysctl.c. "extern" > declaration in *.c file is not appreciated in general. > And Hmm...it seems there are a few redundant declarations. > > Because most of sysctl variables are defined in its own header file, > they should be declared in the same style, be done in its own *.h file. > > This patch removes some VM(memory management) related sysctl's > variable declaration from kernel/sysctl.c and move them to > proper places. > > [rientjes@google.com: #ifdef fixlet] > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Signed-off-by: David Rientjes <rientjes@google.com>
Looks good to me. Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
| |