[lkml]   [2010]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC GIT PULL] perf/trace/lock optimization/scalability improvements
On Wed, Feb 03, 2010 at 11:26:11AM +0100, Ingo Molnar wrote:
> There's one area that needs more thought i think: the dump-all-classes
> init-event-injector approach. It is async, hence we could lose events if
> there's a lot of lock classes to dump.

Yeah, the dump itself is purely async.

But the lock_class_init event is used from two sites:

- the injector, purely aynchronous and catch up from the past

- register_lock_class(), this is the synchronous point, each time
we have a new class created.

When we register a lock_class_init ftrace/perf event, we first activate
the synchronous point, it behaves here as a usual event, and will hook
in every present new events.

And only after, we call the injector, asynchronous, rely on past events.

That beeing split in two part covers every events.

> Plus we eventually want to use your
> injector approach for other things as well (such as to dump the state of a
> collection of tasks) - so i think we want it to be more synchronous.

Yeah, that would work also for tasks. And we can follow the same
pattern for that.

We can set up a synchronous trace point in fork and have a secondary
asynchronous point that can dump the task list. That too would
cover every events we want.

> One approach would be to allow a gradual read() deplete the dump. Also, i
> think the 'state dump' events should be separate from regular init events.
> Filters attached to these events will automatically cause the dumping to be
> restricted to the filter set. For example in the case of tasks one could dump
> only tasks from a particular UID - by adding a 'uid == 1234' filter before
> the dump (on a per tasks basis - so the filtering is nicely task local).

But this is what we want right? If the init event and the dump event are
the same, which is the case currently, the filter will apply to both.

And if we are only interested in tasks for uid == 1234, I guess we
want async and sync events that have the same filter.

May be we want to split up init events from dump events, say,
have an event class that you can open in either async or
sync mode. But I can't figure out a workflow for which it can
be useful.

 \ /
  Last update: 2010-02-03 22:29    [W:0.161 / U:42.940 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site