lkml.org 
[lkml]   [2010]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] radio-si470x-common: -EINVAL overwritten in si470x_vidioc_s_tuner()
    The -EINVAL was overwritten by the si470x_disconnect_check().

    Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
    ---
    Is this needed?

    diff --git a/drivers/media/radio/si470x/radio-si470x-common.c b/drivers/media/radio/si470x/radio-si470x-common.c
    index 4da0f15..65b4a92 100644
    --- a/drivers/media/radio/si470x/radio-si470x-common.c
    +++ b/drivers/media/radio/si470x/radio-si470x-common.c
    @@ -748,12 +748,13 @@ static int si470x_vidioc_s_tuner(struct file *file, void *priv,
    struct v4l2_tuner *tuner)
    {
    struct si470x_device *radio = video_drvdata(file);
    - int retval = -EINVAL;
    + int retval;

    /* safety checks */
    retval = si470x_disconnect_check(radio);
    if (retval)
    goto done;
    + retval = -EINVAL;

    if (tuner->index != 0)
    goto done;

    \
     
     \ /
      Last update: 2010-02-03 20:45    [W:6.075 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site