lkml.org 
[lkml]   [2010]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/10] drivers/ata: Fix continuation line formats
Joe Perches wrote:
> String constants that are continued on subsequent lines with \
> are not good.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/ata/pata_at91.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
> index 41c94b1..d222c0d 100644
> --- a/drivers/ata/pata_at91.c
> +++ b/drivers/ata/pata_at91.c
> @@ -153,8 +153,8 @@ static void pata_at91_set_piomode(struct ata_port *ap, struct ata_device *adev)
> /* Compute ATA timing and set it to SMC */
> ret = ata_timing_compute(adev, adev->pio_mode, &timing, 1000, 0);
> if (ret) {
> - dev_warn(ap->dev, "Failed to compute ATA timing %d, \
> - set PIO_0 timing\n", ret);
> + dev_warn(ap->dev, "Failed to compute ATA timing %d, set PIO_0 timing\n",
> + ret);
..

NAK. Just stick the ret); part onto the same line and be done with it.

-ml


\
 
 \ /
  Last update: 2010-02-03 18:23    [W:1.926 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site