Messages in this thread | | | Subject | Re: [PATCH] drivers/acpi/ec.c fix a small memory leak | From | Bernd Petrovitsch <> | Date | Wed, 03 Feb 2010 12:06:57 +0100 |
| |
On Die, 2010-02-02 at 18:35 +0300, Alexey Starikovskiy wrote: > NAK > > saved_ec is allocated if flag EC_FLAGS_VALIDATE_ECDT is true. > EC_FLAGS_SKIP_DSDT_SCAN have no sense in such case, thus this new code path > is never executed. > On the other hand, unconditionally freeing pointer, which is might be NULL, is not > right either. Why that? "kfree(NULL);" works (and in the user-space "free(NULL)" too FWIW).
> So, this patch introduced more problems as it tries to solve...
Bernd -- Bernd Petrovitsch Email : bernd@petrovitsch.priv.at LUGA : http://www.luga.at
| |