lkml.org 
[lkml]   [2010]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Driver core: Reduce the level of request_firmware() messages
From
Date
Hello Rafael,

On Sun, 2010-02-28 at 13:13 +0100, Rafael J. Wysocki wrote:
> On Sunday 28 February 2010, Jaswinder Singh Rajput wrote:
> > On Sun, Feb 28, 2010 at 2:13 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > > From: Rafael J. Wysocki <rjw@sisk.pl>
> > >
> > > The messages from _request_firmware() informing that firmware is
> > > being requested or built-in firmware is going to be used are printed
> > > at KERN_INFO, which produces lots of noise on systems with huge
> > > numbers of AMD CPUs. Reduce the level of these messages to
> > > KERN_DEBUG to get rid of that noise.
> > >
> >
> > Which firmware we are using is very useful information. Because of
> > huge numbers of CPUs it seems noise then better provide the
> > information for first cpu and for the rest of the CPUs you can show by
> > KERN_DEBUG.
>
> That would have been better indeed, but the problem is _request_firmware()
> doesn't allow us to change the level of its messages on demand.

Can we try this :

if (smp_processor_id())
dev_dbg(..);
else
dev_info(..);
Thanks,
--
Jaswinder Singh.



\
 
 \ /
  Last update: 2010-02-28 17:37    [from the cache]
©2003-2011 Jasper Spaans