Messages in this thread | | | Date | Fri, 26 Feb 2010 23:59:27 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH 14/28] kgdboc,keyboard: Keyboard driver for kdb with kgdb |
| |
On Fri, Feb 26, 2010 at 07:13:03AM -0600, Jason Wessel wrote: > Dmitry Torokhov wrote: > > Hi Jason, > > > > Sorry for not responding earlier. > > > > On Thu, Feb 25, 2010 at 03:21:19PM -0600, Jason Wessel wrote: > >> +++ b/drivers/char/kdb_keyboard.c > > > > Does it have to live here? If you are going for completely separate > > driver maybe it should be buried somewhere like xxx/kdb/kdb_keyboard.c > > so nobody needs to look at it? > > > I think in the long run we could consider integration with the primary > keyboard driver via a polling hook. I am happy to move the driver off > into kernel/debug/kdb with the other kdb related files until that > happens. > > The original logic for putting next to the keyboard.c was because they > are both fighting for the same HW. Please let me know if this changes > your mind, else I will go ahead and move the keyboard implementation > into the kernel/debug/kdb. >
It does not behause in 2.6 the driver talking to the i8042 is called i8042.c and it is located in drivers/input/serio. drivers/char/keyboard.c does not talk directly to hardware anymore and pc_keyb.c is long gone.
Given the fact that your code does not implement a character device I do not see any reason for it to live in drivers/char.
Thanks.
-- Dmitry
| |