Messages in this thread | | | Date | Sat, 27 Feb 2010 12:18:29 -0600 | Subject | Re: [PATCH 2/3] cs5535-gpio: Use set_direction | From | Ben Gardner <> |
| |
>> Use the set_direction method instead of direction_input and direction_output >> to enable use of the bidirectional mode. > > Any reason you aren't making the standard behavior be: > > input ... input enabled > output ... both enabled > > That would make this driver behave like most other GPIO hardware, which > would help you avoid subtle problems. > > Would there be any technical downside to that approach?
That sounds like a good approach.
Ben -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |