lkml.org 
[lkml]   [2010]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: s2disk hang update
    From
    On 2/25/10, Rafael J. Wysocki <rjw@sisk.pl> wrote:
    > On Thursday 25 February 2010, Alan Jenkins wrote:
    >> On 2/24/10, Rafael J. Wysocki <rjw@sisk.pl> wrote:
    >> > On Wednesday 24 February 2010, Alan Jenkins wrote:
    > ...
    >>
    >> > - while (to_free_normal > 0 && to_free_highmem > 0) {
    >> > + while (to_free_normal > 0 || to_free_highmem > 0) {
    >>
    >> Yes, that seems to do it. No more hangs so far (and I can still
    >> reproduce the hang with too many applications if I un-apply the
    >> patch).
    >
    > OK, great. Is this with or without the NOIO-enforcing patch?

    With.

    >> I did see a non-fatal allocation failure though, so I'm still not sure
    >> that the current implementation is strictly correct.
    >>
    >> This is without the patch to increase "to_free_normal". If I get the
    >> allocation failure again, should I try testing the "free 20% extra"
    >> patch?
    >
    > Either that or try to increase SPARE_PAGES. That should actually work with
    > the last patch applied. :-)
    >
    > Rafael

    <grin>, OK.


    \
     
     \ /
      Last update: 2010-02-26 10:29    [W:0.020 / U:30.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site