lkml.org 
[lkml]   [2010]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 14/28] kgdboc,keyboard: Keyboard driver for kdb with kgdb
Hi Jason,

Sorry for not responding earlier.

On Thu, Feb 25, 2010 at 03:21:19PM -0600, Jason Wessel wrote:
> +++ b/drivers/char/kdb_keyboard.c

Does it have to live here? If you are going for completely separate
driver maybe it should be buried somewhere like xxx/kdb/kdb_keyboard.c
so nobody needs to look at it?

> diff --git a/drivers/char/kdb_keyboard.h b/drivers/char/kdb_keyboard.h
> new file mode 100644
> index 0000000..5541668
> --- /dev/null
> +++ b/drivers/char/kdb_keyboard.h
> @@ -0,0 +1,143 @@
> +/*
> + * include/linux/pc_keyb.h
> + *
> + * PC Keyboard And Keyboard Controller
> + *
> + * (c) 1997 Martin Mares <mj@atrey.karlin.mff.cuni.cz>
> + */

The above notwithstanding maybe we should not be bringing 2.4 codebase
as is in 2.6 and instead use (and extend as needed) definitions that are
already present?

--
Dmitry


\
 
 \ /
  Last update: 2010-02-26 09:01    [W:0.037 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site