lkml.org 
[lkml]   [2010]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] backlight, classmate-laptop: fix missing registration failure handling
    Mathew,

    Please apply the following patch.

    Acked-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

    On Fri, Feb 26, 2010 at 12:59:39PM +0100, Bruno Prémont wrote:
    > Check newly registered backlight_device for error and properly
    > return error to parent.
    > Mark struct backlight_ops as const.
    >
    > Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
    > ---
    > drivers/platform/x86/classmate-laptop.c | 2 +++-
    > 1 files changed, 3 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c
    > index bfae789..66f6aad 100644
    > --- a/drivers/platform/x86/classmate-laptop.c
    > +++ b/drivers/platform/x86/classmate-laptop.c
    > @@ -452,7 +452,7 @@ static int cmpc_bl_update_status(struct backlight_device *bd)
    > return -1;
    > }
    >
    > -static struct backlight_ops cmpc_bl_ops = {
    > +static const struct backlight_ops cmpc_bl_ops = {
    > .get_brightness = cmpc_bl_get_brightness,
    > .update_status = cmpc_bl_update_status
    > };
    > @@ -463,6 +463,8 @@ static int cmpc_bl_add(struct acpi_device *acpi)
    >
    > bd = backlight_device_register("cmpc_bl", &acpi->dev,
    > acpi->handle, &cmpc_bl_ops);
    > + if (IS_ERR(bd))
    > + return PTR_ERR(bd);
    > bd->props.max_brightness = 7;
    > dev_set_drvdata(&acpi->dev, bd);
    > return 0;
    > --
    > 1.6.4.4
    >
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2010-02-26 17:29    [W:2.661 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site