Messages in this thread Patch in this message | | | From | Matthew Garrett <> | Subject | [PATCH 07/14] dell-laptop: Block software state changes when rfkill hard blocked | Date | Fri, 26 Feb 2010 10:18:40 -0500 |
| |
From: Mario Limonciello <Mario_Limonciello@Dell.com>
The "hardware" switch is tied directly to a BIOS interface that will connect and disconnect the hardware from the bus.
If you use the software interface to request the BIOS to make these changes, the HW switch will be in an inconsistent state and LEDs may not reflect the state of the HW.
Signed-off-by: Mario Limonciello <Mario_Limonciello@Dell.com> --- drivers/platform/x86/dell-laptop.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index b13eb6a..81213e8 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -190,6 +190,10 @@ static int dell_rfkill_set(void *data, bool blocked) unsigned long radio = (unsigned long)data; memset(&buffer, 0, sizeof(struct calling_interface_buffer)); + dell_send_request(&buffer, 17, 11); + if (!(buffer.output[1] & BIT(16))) + return -EINVAL; + buffer.input[0] = (1 | (radio<<8) | (disable << 16)); dell_send_request(&buffer, 17, 11); -- 1.6.6.1
| |