lkml.org 
[lkml]   [2010]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] cgroup: do not use dprintf in cgroup_event_listener
Date
glibc's dprintf(3) is buggy:
http://sourceware.org/bugzilla/show_bug.cgi?id=11319

Let's not to use it in the example.

Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
---
Documentation/cgroups/cgroup_event_listener.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/Documentation/cgroups/cgroup_event_listener.c b/Documentation/cgroups/cgroup_event_listener.c
index 8c2d7aa..8c2bfc4 100644
--- a/Documentation/cgroups/cgroup_event_listener.c
+++ b/Documentation/cgroups/cgroup_event_listener.c
@@ -23,6 +23,7 @@ int main(int argc, char **argv)
int cfd = -1;
int event_control = -1;
char event_control_path[PATH_MAX];
+ char line[LINE_MAX];
int ret;

if (argc != 3) {
@@ -39,7 +40,7 @@ int main(int argc, char **argv)

ret = snprintf(event_control_path, PATH_MAX, "%s/cgroup.event_control",
dirname(argv[1]));
- if (ret > PATH_MAX) {
+ if (ret >= PATH_MAX) {
fputs("Path to cgroup.event_control is too long\n", stderr);
goto out;
}
@@ -57,7 +58,13 @@ int main(int argc, char **argv)
goto out;
}

- ret = dprintf(event_control, "%d %d %s", efd, cfd, argv[2]);
+ ret = snprintf(line, LINE_MAX, "%d %d %s", efd, cfd, argv[2]);
+ if (ret >= LINE_MAX) {
+ fputs("Arguments string is too long\n", stderr);
+ goto out;
+ }
+
+ ret = write(event_control, line, strlen(line) + 1);
if (ret == -1) {
perror("Cannot write to cgroup.event_control");
goto out;
--
1.6.6.2


\
 
 \ /
  Last update: 2010-02-25 11:27    [W:0.057 / U:1.892 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site