[lkml]   [2010]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap
    On Thu, 25 Feb 2010, Pekka Enberg wrote:

    > > > > > I'm just worried there is still an underlying problem here.
    > > > > So am I. What caused the breakage that requires this patchset?
    > > > Memory hotadd with a new node being onlined.
    > >
    > > That used to work fine.
    > OK, can we get this issue resolved? The merge window is open and Christoph
    > seems to be unhappy with the whole patch queue. I'd hate this bug fix to miss
    > .34...

    I don't see how memory hotadd with a new node being onlined could have
    worked fine before since slab lacked any memory hotplug notifier until
    Andi just added it.

    That said, I think the first and fourth patch in this series may be
    unnecessary if slab's notifier were to call slab_node_prepare() on
    MEM_GOING_ONLINE instead of MEM_ONLINE. Otherwise, kswapd is already
    running, the zonelists for the new pgdat have been initialized, and the
    bit has been set in node_states[N_HIGH_MEMORY] without allocated
    cachep->nodelists[node] memory.

     \ /
      Last update: 2010-02-25 09:03    [W:0.021 / U:12.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site