Messages in this thread Patch in this message | | | Date | Thu, 25 Feb 2010 11:18:34 GMT | From | "tip-bot for Zhang, Yanmin" <> | Subject | [tip:perf/core] perf symbols: Check the right return variable |
| |
Commit-ID: 37fe5fcb7a5b5235c8b71bf5469ce4c7246e3fab Gitweb: http://git.kernel.org/tip/37fe5fcb7a5b5235c8b71bf5469ce4c7246e3fab Author: Zhang, Yanmin <yanmin_zhang@linux.intel.com> AuthorDate: Thu, 25 Feb 2010 11:00:51 +0800 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Thu, 25 Feb 2010 12:15:24 +0100
perf symbols: Check the right return variable
In function dso__split_kallsyms(), curr_map saves the return value of map__new2. So check it instead of var map after the call returns.
Signed-off-by: Zhang Yanmin <yanmin_zhang@linux.intel.com> Acked-by: David S. Miller <davem@davemloft.net> Cc: <stable@kernel.org> # for .33.x Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul Mackerras <paulus@samba.org> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> LKML-Reference: <1267066851.1726.9.camel@localhost> Signed-off-by: Ingo Molnar <mingo@elte.hu> --- tools/perf/util/symbol.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index ee9c37e..320b151 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -527,7 +527,7 @@ static int dso__split_kallsyms(struct dso *self, struct map *map, return -1; curr_map = map__new2(pos->start, dso, map->type); - if (map == NULL) { + if (curr_map == NULL) { dso__delete(dso); return -1; }
| |