Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [PATCH 2/3] hid: add suspend/resume hooks for hid drivers | Date | Thu, 25 Feb 2010 05:19:46 +0100 |
| |
Am Mittwoch, 24. Februar 2010 17:01:12 schrieb Bruno Prémont: > Add suspend/resume hooks for HID drivers so these can do some > additional state adjustment when device gets suspended/resumed. > > This patch calls these hooks from usbhid suspend/resume functions, > only calling suspend on plain suspend, not autosuspend. > (it might be worth adding an autosuspend parameter to suspend > hook and calling suspend in both cases)
This is quite dirty. A driver that was autosuspended may be non-auto resumed. Secondly, do you really want to call the hook for reset_resume() if hid_post_reset() has failed?
Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |