Messages in this thread | | | Date | Wed, 24 Feb 2010 16:05:18 -0600 | From | Jack Steiner <> | Subject | Re: Panic in reserve_memtype() |
| |
> > I guess I found an obvious problem in the code. Can you check whether the > below patch resolves the panic you are seeing. > > Thanks, > Venki
Works great!! Thanks...
> > > new->type should only change when there is a valid ret_type. Otherwise > requested type and return type should be same. > > Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> > --- > arch/x86/mm/pat_rbtree.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/mm/pat_rbtree.c b/arch/x86/mm/pat_rbtree.c > index e4cd229..58b6de1 100644 > --- a/arch/x86/mm/pat_rbtree.c > +++ b/arch/x86/mm/pat_rbtree.c > @@ -223,7 +223,9 @@ int rbt_memtype_check_insert(struct memtype *new, unsigned long *ret_type) > new->type, ret_type); > > if (!err) { > - new->type = *ret_type; > + if (ret_type) > + new->type = *ret_type; > + > memtype_rb_insert(&memtype_rbroot, new); > } > return err; > -- > 1.6.0.6
| |