lkml.org 
[lkml]   [2010]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH -mmotm] cgroup: fix typo in error handling in cgroup_write_event_control()
    From
    On Wed, Feb 24, 2010 at 5:31 AM, Kirill A. Shutemov
    <kirill@shutemov.name> wrote:
    > Actually, we want to fput() cfile, if cfile is not NULL.
    >
    > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>

    Thanks.

    Acked-by: Paul Menage <menage@google.com>

    > ---
    >  kernel/cgroup.c |    2 +-
    >  1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/kernel/cgroup.c b/kernel/cgroup.c
    > index d142524..049ce0d 100644
    > --- a/kernel/cgroup.c
    > +++ b/kernel/cgroup.c
    > @@ -3117,7 +3117,7 @@ static int cgroup_write_event_control(struct cgroup *cgrp, struct cftype *cft,
    >        return 0;
    >
    >  fail:
    > -       if (!cfile)
    > +       if (cfile)
    >                fput(cfile);
    >
    >        if (event && event->eventfd && !IS_ERR(event->eventfd))
    > --
    > 1.6.6.2
    >
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-02-24 17:07    [W:0.021 / U:0.644 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site