lkml.org 
[lkml]   [2010]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/14] Regulators: wm8994 - clean up driver data after removal
On Tue, Feb 23, 2010 at 11:38:44PM -0800, Dmitry Torokhov wrote:
> It is a good tone to reset driver data after unbinding the device.

You mean "good style" here. Anyway,

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

BTW, this patch is an example of the sort of stuff I'm talking about
with adding additional changes that aren't documented in the
changelog. As well as nulling out the driver data you're also...

> struct wm8994_ldo {
> int enable;
> - int is_enabled;
> + bool is_enabled;

...doing a conversion to bool here and...

> @@ -276,6 +278,7 @@ static struct platform_driver wm8994_ldo_driver = {
> .remove = __devexit_p(wm8994_ldo_remove),
> .driver = {
> .name = "wm8994-ldo",
> + .owner = THIS_MODULE,
> },

...adding this. The change you mention in the changelog is a single
line edit but with these extra changes the overall diffstat becomes:

> drivers/regulator/wm8994-regulator.c | 11 +++++++----
> 1 files changed, 7 insertions(+), 4 deletions(-)


\
 
 \ /
  Last update: 2010-02-24 11:23    [W:0.162 / U:5.044 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site