[lkml]   [2010]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 00/14] Assorted small patches for regulators
On Tue, Feb 23, 2010 at 11:37:39PM -0800, Dmitry Torokhov wrote:

> I happend to peek into drivers/regulator and saw a bunch of small issues, so
> here goes. The patches are against linux-next, compile-tested only since I
> don't have the hardware,

I'm working through these now, but a few general issues:

- It'd be very much easier to review patches that do one thing at once,
especially when the patches do things more invasive than just adding
annotations or changing types. The random cleanup stuff makes the
invasive changes much harder to see and review.
- Frequently your patches include additional changes above those that
you list in the changelog which again increases the effort require to
reviwe - things like random whitespace changes and the addition of
module annotations seem particularly prone to this.
- Please always use a subject line for your patches which fits the
style of the subsystem. You're using "Regulators:" as a prefix when
pretty much everything else uses "regulator:".

 \ /
  Last update: 2010-02-24 11:05    [W:0.176 / U:2.584 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site