Messages in this thread | | | Date | Tue, 23 Feb 2010 10:28:53 +0100 | From | Andrea Righi <> | Subject | Re: [PATCH 1/2] memcg: dirty pages accounting and limiting infrastructure |
| |
On Mon, Feb 22, 2010 at 09:44:42PM +0530, Balbir Singh wrote: [snip] > > +void mem_cgroup_charge_dirty(struct page *page, > > + enum zone_stat_item idx, int charge) > > +{ > > + struct mem_cgroup *mem; > > + struct mem_cgroup_stat_cpu *cpustat; > > + unsigned long flags; > > + int cpu; > > + > > + if (mem_cgroup_disabled()) > > + return; > > + /* Translate the zone_stat_item into a mem_cgroup_stat_index */ > > + switch (idx) { > > + case NR_FILE_DIRTY: > > + idx = MEM_CGROUP_STAT_FILE_DIRTY; > > + break; > > + case NR_WRITEBACK: > > + idx = MEM_CGROUP_STAT_WRITEBACK; > > + break; > > + case NR_WRITEBACK_TEMP: > > + idx = MEM_CGROUP_STAT_WRITEBACK_TEMP; > > + break; > > + case NR_UNSTABLE_NFS: > > + idx = MEM_CGROUP_STAT_UNSTABLE_NFS; > > + break; > > + default: > > + return; > > + } > > + /* Charge the memory cgroup statistics */ > > + mem = get_mem_cgroup_from_page(page); > > + if (!mem) { > > + mem = root_mem_cgroup; > > + css_get(&mem->css); > > + } > > + > > + local_irq_save(flags); > > + cpu = get_cpu(); > > Kamezawa is in the process of changing these, so you might want to > look at and integrate with those patches when they are ready.
OK, I'll rebase the patch to -mm. Are those changes already included in mmotm?
Thanks, -Andrea
| |