Messages in this thread | | | Date | Mon, 22 Feb 2010 12:57:11 +0200 | From | Pekka Enberg <> | Subject | Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap |
| |
Christoph Lameter kirjoitti: > On Mon, 15 Feb 2010, Andi Kleen wrote: > >>> How, may I ask? cpuup_prepare in the hotplug notifier should always >>> run before start_cpu_timer. >> I'm not fully sure, but I have the oops to prove it :) > > I still suspect that this has something to do with Pekka's changing the > boot order for allocator bootstrap. Can we clarify why these problems > exist before we try band aid?
I don't see how my changes broke things but maybe I'm not looking hard enough. Cache reaping is still setup from cpucache_init() which is an initcall which is not affected by my changes AFAICT and from cpuup_callback() which shoulda also not be affected.
Pekka
| |