lkml.org 
[lkml]   [2010]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/10] namespace: perlcritic warnings
On Sat, 20 Feb 2010 16:26:24 +0800
Hui Zhu <teawater@gmail.com> wrote:

> On Sat, Feb 20, 2010 at 01:52, Stephen Hemminger <shemminger@vyatta.com> wrote:
> > Use local file handle not global.
> > Make loop and other variables local in scope.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> >
> >
> > --- a/scripts/namespace.pl      2010-02-19 08:59:00.432184740 -0800
> > +++ b/scripts/namespace.pl      2010-02-19 09:05:52.672644797 -0800
> > @@ -175,12 +175,11 @@ sub do_nm
> >        }
> >        if (! -e "$source.c" && ! -e "$source.S") {
> >                # No obvious source, exclude the object if it is conglomerate
> > -               if (! open(OBJDUMPDATA, "$objdump $basename|")) {
> > -                       printf STDERR "$objdump $fullname failed $!\n";
> > -                       return;
> > -               }
> > +               open(my $objdumpdata, "$objdump $basename|")
> > +                   or die "$objdump $fullname failed $!\n";
>
> Looks it just want return, are you sure have to change it to die?

Read my previous comment
> If objdump program is missing program should die with message
> to standard error and exit with non zero status, not continue on!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-02-22 17:45    [W:0.039 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site