lkml.org 
[lkml]   [2010]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] ftrace - add support for tracing_thresh to function_graph tracer
From
Date
On Sat, 2010-02-20 at 15:43 +0100, Frederic Weisbecker wrote:
>
> Instead of having yet another check here, may be should we
> have a dedicated stub trace_graph_entry?
>
>
>
> > @@ -254,6 +263,10 @@ static void __trace_graph_return(struct trace_array *tr,
> > if (unlikely(__this_cpu_read(per_cpu_var(ftrace_cpu_disabled))))
> > return;
> >
> > + if (tracing_thresh &&
> > + (trace->rettime - trace->calltime < tracing_thresh))
> > + return;
> > +
>
>
>
> And perhaps we can do the same for the return handler?
> We could have a trace_graph_return_threshold that
> performs the above check and then relies on trace_graph_return.

So you mean to register a different type of function to the graph tracer
if trace_thresh is enabled? That does sound like a better idea.

-- Steve




\
 
 \ /
  Last update: 2010-02-22 16:01    [W:1.185 / U:1.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site