Messages in this thread | | | Subject | Re: [PATCH 1/1] ftrace - add support for tracing_thresh to function_graph tracer | From | Steven Rostedt <> | Date | Mon, 22 Feb 2010 09:57:43 -0500 |
| |
On Sat, 2010-02-20 at 15:43 +0100, Frederic Weisbecker wrote: > > Instead of having yet another check here, may be should we > have a dedicated stub trace_graph_entry? > > > > > @@ -254,6 +263,10 @@ static void __trace_graph_return(struct trace_array *tr, > > if (unlikely(__this_cpu_read(per_cpu_var(ftrace_cpu_disabled)))) > > return; > > > > + if (tracing_thresh && > > + (trace->rettime - trace->calltime < tracing_thresh)) > > + return; > > + > > > > And perhaps we can do the same for the return handler? > We could have a trace_graph_return_threshold that > performs the above check and then relies on trace_graph_return.
So you mean to register a different type of function to the graph tracer if trace_thresh is enabled? That does sound like a better idea.
-- Steve
| |